feat(IT Wallet): [SIW-3261] Add logic to handle L2+ identification for PID issuance #7537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
mastro993
requested review from
a team,
Alessandro-Laregina,
ChrisMattew,
freddi301 and
gispada
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7537 +/- ##
=======================================
Coverage 59.66% 59.67%
=======================================
Files 1859 1860 +1
Lines 40313 40313
Branches 9257 9314 +57
=======================================
+ Hits 24053 24055 +2
+ Misses 16188 16174 -14
- Partials 72 84 +12
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ale-mazz
approved these changes
Nov 3, 2025
Contributor
ale-mazz
left a comment
ale-mazz
left a comment
There was a problem hiding this comment.
Tested every requested scenario. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR refactors the eID issuance state machine to generalize the logic for handling different identification levels. This change improves extensibility and prepares the flow for the upcoming L2+ identification method.
List of changes proposed in this pull request
EidIssuanceLeveltype to define the identification level (and its variations) used during PID issuance. Available values:l2: Documenti su IO issuance using CIE+PIN, CIEID, or SPIDl2-fallback: Documenti su IO issuance using CIEID or SPID (fallback mode)l3: IT Wallet issuance using CIE+PIN or CIEIDl3-next: IT Wallet issuance using CIE+PIN and L2+ (SPID or CIEID with CIE PACE/Internal auth)levelparameter to the eID machine context and thestart/restartevents, replacing the previousisL3andisL2Fallbackflags.isL3IssuanceFeaturesEnabledutility function to determine if the issuance flow is for an L3 or L2 PIDstartandrestartevents now require all parameters to be explicitly provided.Note
l3andl3-nextwill be merged once the L2+ flow will become available to all usersHow to test
Verify that no regressions are introduced in the following flows: